Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bulk response has errors indication + status per item #4002

Closed
costin opened this issue Oct 29, 2013 · 2 comments
Closed

bulk response has errors indication + status per item #4002

costin opened this issue Oct 29, 2013 · 2 comments
Assignees
@kimchy
Labels
>enhancement v1.0.0.RC1

Comments

@costin
Copy link
Member

costin commented Oct 29, 2013

When using the bulk API, in case of an error for one of the actions specified, the client needs to parse the entire response to figure out whether all of them succeeded or not.

Having a simple boolean field ("errors" : true/false) indicating whether all requests worked or at least one failed would help a lot as the response does not have to be parsed any more.
@kimchy
Copy link
Member

kimchy commented Oct 29, 2013

while we do this, it would also be nice to have a status element on each failed item, with the status code for the failure.

@roytmana
Copy link

Do we even need to return the complete list. Could we just return lost of failures with each failure carrying its original index so it can be matched to the bulk request element?
This way return will be much smaller without loss of info.

@ghost ghost assigned kimchy Dec 11, 2013
@kimchy kimchy closed this as completed in a3f1c42 Dec 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kimchy kimchy

Labels
>enhancement v1.0.0.RC1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kimchy @costin @roytmana